Deprecate oc secrets subcomands #18093
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
|
LGTM You will need to update the release notes for 3.9 and mark them as deprecated and being removed in 3.10. The release note issue should be in openshift-docs. |
Once this merges I'll update the docs. We are using this in several places and that needs to be changed as well. |
|
/retest |
| @@ -44,11 +44,6 @@ func NewCmdSecrets(name, fullName string, f *clientcmd.Factory, reader io.Reader | |||
| Run: cmdutil.DefaultSubCommandRun(errOut), | |||
| } | |||
|
|
|||
| newSecretFullName := fullName + " " + NewSecretRecommendedCommandName | |||
| cmds.AddCommand(NewCmdCreateSecret(NewSecretRecommendedCommandName, newSecretFullName, f, out)) | |||
There was a problem hiding this comment.
I expect a deprecation warning, but I still expect to be able to run oc secret create. Is this not doing what I think it's doing?
There was a problem hiding this comment.
I believe they are still being added to the oc secrets tree here https://github.com/openshift/origin/pull/18093/files#diff-98f0c62da95151f788ac0edc23423802R200, but with the deprecation warning
There was a problem hiding this comment.
Yes, you still can run those, it'll just scream after you with the deprecation.
pkg/oc/cli/secrets/basicauth.go
Outdated
| @@ -69,6 +69,9 @@ func NewCmdCreateBasicAuthSecret(name, fullName string, f kcmdutil.Factory, read | |||
| Short: "Create a new secret for basic authentication", | |||
| Long: createBasicAuthSecretLong, | |||
| Example: fmt.Sprintf(createBasicAuthSecretExample, fullName, newSecretFullName, ocEditFullName), | |||
| PreRun: func(cmd *cobra.Command, args []string) { | |||
There was a problem hiding this comment.
I'm going to change this to Deprecated variable in cobra.Command.
soltysh
force-pushed
the
deprecate_secrets
branch
from
6a555ca to
2a562fc
Compare
openshift-ci-robot
added
size/XL
|
This is ready to go, @deads2k @juanvallejo make the honors |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
|
/test extended_conformance_install |
|
Automatic merge from submit-queue (batch tested with PRs 17976, 17195, 18093, 18080, 17922). |
While recently working on the secrets issue I've noticed we have a set of
oc secretssubcommands that can be easily replaced withoc create secretcommand. Thus, after discussing this topic with @juanvallejo and @deads2k I'm deprecating them./assign @juanvallejo @deads2k